Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add --short-name flag for resource creation commands #419

Merged
merged 1 commit into from
Sep 9, 2019
Merged

add --short-name flag for resource creation commands #419

merged 1 commit into from
Sep 9, 2019

Conversation

carlory
Copy link
Member

@carlory carlory commented Sep 8, 2019 •
edited
Loading

ref: #249

@k8s-ci-robot
Copy link
Contributor

Welcome @carlory!

It looks like this is your first PR to kubernetes-sigs/apiserver-builder-alpha 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/apiserver-builder-alpha has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 8, 2019
@carlory
Copy link
Member Author

carlory commented Sep 8, 2019

/assign @yue9944882

yue9944882
yue9944882 approved these changes Sep 9, 2019
View reviewed changes
Copy link
Member

@yue9944882 yue9944882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, couple of nits otherwise LGTM

cmd/apiserver-boot/boot/create/resource.go Outdated
@@ -54,6 +55,7 @@ apiserver-boot create group version resource --group insect --version v1beta1 --
func AddCreateResource(cmd *cobra.Command) {
RegisterResourceFlags(createResourceCmd)

createResourceCmd.Flags().StringVar(&shortName, "short-name", "", "if set, add a short name for the resource, exposed in API discovery documents, and used by clients to support invocations like 'kubectl get <shortname>'. It must be all lowercase.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"if set, add a short name for the resource, exposed in API discovery documents, and used by clients to support invocations like 'kubectl get '. It must be all lowercase."

cmd/apiserver-boot/boot/create/util.go Outdated
if len(shortName) > 0 {
if errs := utilvalidation.IsDNS1035Label(shortName); len(errs) > 0 {
detail := strings.Join(errs, ",")
klog.Fatalf("--short-name has bad format. %q : %s", shortName, detail)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
klog.Fatalf("--short-name has bad format. %q : %s", shortName, detail)
klog.Fatalf("--short-name %q has bad format: %s", shortName, detail)

cmd/apiserver-boot/boot/create/util.go Outdated
"regexp"
"strings"

"k8s.io/klog"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move it below L30

cmd/apiserver-boot/boot/create/resource.go Outdated
@@ -323,7 +327,7 @@ import (

// {{.Kind}}
// +k8s:openapi-gen=true
// +resource:path={{.Resource}},strategy={{.Kind}}Strategy
// +resource:path={{.Resource}},strategy={{.Kind}}Strategy{{- if .ShortName }},shortname={{.ShortName}}{{- end }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// +resource:path={{.Resource}},strategy={{.Kind}}Strategy{{- if .ShortName }},shortname={{.ShortName}}{{- end }}
// +resource:path={{.Resource}},strategy={{.Kind}}Strategy{{ if .ShortName }},shortname={{.ShortName}}{{ end }}

@carlory
Copy link
Member Author

carlory commented Sep 9, 2019

@yue9944882 fixed!

@carlory
Copy link
Member Author

carlory commented Sep 9, 2019

@DirectXMan12 @yue9944882 it is ready for review.

@yue9944882
Copy link
Member

thanks!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2019
@k8s-ci-robot k8s-ci-robot merged commit 733ee74 into kubernetes-sigs:master Sep 9, 2019
@carlory carlory deleted the feature/shortnames branch September 9, 2019 12:25
@carlory carlory mentioned this pull request Jan 5, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yue9944882 yue9944882 yue9944882 approved these changes

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

Assignees

@yue9944882 yue9944882

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlory @k8s-ci-robot @yue9944882