Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Support built-in admission controller for aggregated resource #361

Conversation

yue9944882
Copy link
Member

a dummy admission controller will be generated when specifying --admission-controller in the apiserver-boot create resource commands.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 11, 2019
@yue9944882 yue9944882 force-pushed the feat/admission-controller-support branch 3 times, most recently from f8d48fb to 0f08a91 Compare June 11, 2019 11:06
@yue9944882 yue9944882 force-pushed the feat/admission-controller-support branch from 0f08a91 to 4a7f9f0 Compare June 25, 2019 14:57
@danielfbm
Copy link

+1

@yue9944882 yue9944882 force-pushed the feat/admission-controller-support branch from 4a7f9f0 to 554a613 Compare June 26, 2019 08:03
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 26, 2019
…roller`

extend Config fields w/ admission controller and post-start hooks
@yue9944882 yue9944882 force-pushed the feat/admission-controller-support branch from 554a613 to 93b61fc Compare June 26, 2019 08:43
@yue9944882 yue9944882 added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jun 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d2afba0 into kubernetes-sigs:master Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants