Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ShortNameProvider #283

Closed
wants to merge 1 commit into from
Closed

Conversation

magicsong
Copy link
Contributor

Passed in my environment. need more tests if possible.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 13, 2018
@magicsong
Copy link
Contributor Author

magicsong commented Dec 13, 2018

/assign @yue9944882

@magicsong
Copy link
Contributor Author

ref #249

@ghost
Copy link

ghost commented Feb 13, 2019

I'd like to see some movement on this, will test this patch in a bit.

@magicsong
Copy link
Contributor Author

/assign @yue9944882

@ghost
Copy link

ghost commented Apr 25, 2019

Sorry, had a chance to test this change now. Did not seem to work, but maybe i just messed up.

@yue9944882
Copy link
Member

by #327, we migrated REST strategies to unversioned pkg so we can extend the short names on that.
@magicsong are you planing to take a rebase? or i'll split another pass.

@danielfbm
Copy link

+1

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign pwittrock
You can assign the PR to them by writing /assign @pwittrock in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 27, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 27, 2019
@magicsong
Copy link
Contributor Author

Apologized to who are caring about this feature.
@yue9944882 ptal

@yue9944882
Copy link
Member

@magicsong i split another pass for the feature, ref #369

@magicsong
Copy link
Contributor Author

@yue9944882 🙏 it is ok to close this pr now

@magicsong magicsong closed this Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants