-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ShortNameProvider #283
Conversation
/assign @yue9944882 |
ref #249 |
I'd like to see some movement on this, will test this patch in a bit. |
/assign @yue9944882 |
Sorry, had a chance to test this change now. Did not seem to work, but maybe i just messed up. |
by #327, we migrated REST strategies to unversioned pkg so we can extend the short names on that. |
+1 |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Apologized to who are caring about this feature. |
@magicsong i split another pass for the feature, ref #369 |
@yue9944882 🙏 it is ok to close this pr now |
Passed in my environment. need more tests if possible.