Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blank fields in "openssl req" subj argument will fail the command for older openssl versions. #186

Closed
yaxinlx opened this issue Oct 19, 2017 · 2 comments · Fixed by #188
Closed

blank fields in "openssl req" subj argument will fail the command for older openssl versions. #186

yaxinlx opened this issue Oct 19, 2017 · 2 comments · Fixed by #188

Comments

@yaxinlx
Copy link
Contributor

yaxinlx commented Oct 19, 2017 •
edited
Loading

It looks order openssl versions will throw errors if some fields in the subj arguments are blank.

https://github.com/kubernetes-incubator/apiserver-builder/blob/master/cmd/apiserver-boot/boot/build/build_resource_config.go#L182
https://github.com/kubernetes-incubator/apiserver-builder/blob/master/cmd/apiserver-boot/boot/build/build_resource_config.go#L196

The issue, minio/minio#3903, in another project suggests a solution.
I have verified -subj /C=un/ST=st/L=l/O=o/OU=ou/CN=%s-certificate-authority works.
@pwittrock
Copy link
Contributor

@yaxinlx Cool. Want to file a fix?

yaxinlx pushed a commit to yaxinlx/apiserver-builder that referenced this issue Oct 21, 2017
avoid errors in "openssl req" command for old openssl versions.
91e9d65 
fixed kubernetes-sigs#186
@yaxinlx yaxinlx mentioned this issue Oct 21, 2017
Merged
@yaxinlx
Copy link
Contributor Author

yaxinlx commented Oct 21, 2017

submitted a pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

avoid errors in "openssl req" command for old openssl versions. yaxinlx/apiserver-builder
2 participants
@pwittrock @yaxinlx