Checksum reconciled Instances and Bindings #582
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
I didn't realize I wasn't working from master :( I'll rebase tomorrow. I was experiencing some local env weirdness today that I didn't have time to sort out, but integration tests should work. |
pmorie
force-pushed
the
checksum-reconciled-instance
branch
from
7d40022
to
dda64f6
Compare
pmorie
changed the title
|
Tested that this has the desired effect on Instance. Implemented for Binding but not tested yet. |
pmorie
changed the title
pmorie
force-pushed
the
checksum-reconciled-instance
branch
from
f396242
to
0e1a8f2
Compare
|
Verified as working on Instances and Bindings |
pmorie
force-pushed
the
checksum-reconciled-instance
branch
from
0e1a8f2
to
89dbfc3
Compare
pmorie
changed the title
Regenerate code more generation
pmorie
force-pushed
the
checksum-reconciled-instance
branch
from
89dbfc3
to
05097cf
Compare
| specString += fmt.Sprintf("parameters:\n\n%v\n\n", string(spec.Parameters.Raw)) | ||
| } | ||
|
|
||
| specString += fmt.Sprintf("osbGuid: %v\n", spec.OSBGUID) |
There was a problem hiding this comment.
What is the need in producing the hash with anything other than the OSBGUID?
There was a problem hiding this comment.
The OSBGuid is static and not expected to change. In fact, I could probably have omitted it from the checksum. The fields which are important to checksum are the ones that will mean that the instance needs to be updated at the broker. Overall I was trying to capture those; it's okay to have fields like the OSBGUID which are static.
|
This LGTM. I have verified that instances are not re-provisioned and bindings are not re-bound as well. |
| Name: "test-instance", | ||
| }, | ||
| SecretName: "test-secret", | ||
| Checksum: func() *string { |
There was a problem hiding this comment.
Can this not just be:
Checksum: "boo"
There was a problem hiding this comment.
Nah, it's a pointer to a string :-/
| allErrs = append(allErrs, ValidateBinding(new)...) | ||
| allErrs = append(allErrs, ValidateBinding(old)...) | ||
| return allErrs | ||
| return internalValidateBinding(new, false) |
There was a problem hiding this comment.
@pmorie why only check the new binding? Bindings can't be updated?
Solves #573 for reprovisions
TLDR: