add a trigger for false status ServiceBinding at the end of SI reconc… #2771
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @jasiu001. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-ok-to-test
k8s-ci-robot
added
the
size/M
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
| @@ -2990,6 +2991,27 @@ func (c *controller) handleServiceInstancePollingError(instance *v1beta1.Service | |||
| return c.continuePollingServiceInstance(instance) | |||
| } | |||
|
|
|||
| // triggerServiceBindingReconciliation adds an annotation to each ServiceBindings, with false status conditions | |||
There was a problem hiding this comment.
.. to each ServiceBinding which is ready...
| if c.isServiceBindingSucceeded(binding) { | ||
| continue | ||
| } | ||
| toUpdate := binding.DeepCopy() |
There was a problem hiding this comment.
please log with info level the binding is triggered
| @@ -2990,6 +2991,27 @@ func (c *controller) handleServiceInstancePollingError(instance *v1beta1.Service | |||
| return c.continuePollingServiceInstance(instance) | |||
| } | |||
|
|
|||
| // triggerServiceBindingReconciliation adds an annotation to each ServiceBindings, with false status conditions | |||
There was a problem hiding this comment.
| // triggerServiceBindingReconciliation adds an annotation to each ServiceBindings, with false status conditions | |
| // triggerServiceBindingReconciliation adds an annotation to every ServiceBinding whose ServiceInstance finishes with success. |
jasiu001
force-pushed
the
binding-trigger
branch
2 times, most recently
from
926efbd
to
de4a510
Compare
jasiu001
force-pushed
the
binding-trigger
branch
from
de4a510
to
710b99d
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jasiu001, piotrmiskiewicz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
This PR is a
What this PR does / why we need it:
There are situations when Service Instance and Service Binding are applying at the same time (used e.g. in automation scripts). In those cases usually, ServiceBinding will end with
failstatus because of a lack of ServiceInstance.ServiceBinding will be reconciled again because of re-sync of the informer, the default value is set to 5 min, but if the user sets the
resyncIntervalvalue higher, then re-reconcilation will be made later.The solution is to trigger each ServiceBinding with
failedstatus to re-reconciliation if ServiceInstance belonging to this SB will end with success.This PR introduces such a change.
Please leave this checklist in the PR comment so that maintainers can ensure a good PR.
Merge Checklist:
breaking the chart release and existing clients who provide a
flag that will get an error when they try to update