-
Notifications
You must be signed in to change notification settings - Fork 382
Add option to execute e2e test both locally and CI #2690
Add option to execute e2e test both locally and CI #2690
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mszostok The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a78df93
to
cc1af7f
Compare
Having never run kind before, my local run ends with:
Looks to me like it built the image, but not with the expected name in the next step? |
From logs I can see that cluster was created, so kind was installed successfully. What was the output of at the end, there should be |
Added above, last line is |
ok, now I see the problem. You have the env REGISTRY configured. I assumed that everyone will have that empty by default. To solve that issue I will change the
and
into
so that will change envs temporary only for that particular command, thanks to that everyone will have the same setup. thanks for finding that 🙂 btw. there is also an option to execute |
Oh, you're right, good catch! It's in my envrc, I probably don't need it set anymore. $ cat .envrc
# for running contrib/jenkins/test_walkthrough.sh
export REGISTRY=quay.io/kubernetes-service-catalog/
# export VERSION=v0.0.21
# export CLEANUP=true
# for make test-e2e
export SERVICECATALOGCONFIG=~/.kube/config
export KUBECONFIG=~/.kube/config Giving it another go around. |
Works good. I'm impressed. /lgtm |
5478f39
to
004b08b
Compare
@MHBauer I only squashed commits, so ur |
- Refactor code for running the e2e test. Tests can be executed both on CI and locally by executing `make test-e2e` - Remove the outdated Jenkins folder/scripts - Update documentation about e2e tests - Move all CI scripts to a single folder
004b08b
to
b757ce4
Compare
/lgtm |
😄 |
Description
This PR enables e2e test on CI with Kuberentes 1.15
Done:
make test-e2e
https://status.build.kyma-project.io/view/gcs/kyma-prow-logs/logs/post-test-sc-e2e-job/1162418742185955328
TODO:
Resolves #2659