Fix deprovisioning process in TestBroker

[jasiu001]

This PR is a

• Feature Implementation
• Bug Fix
• Documentation

What this PR does / why we need it:
The PR fixes deprovisioning ServiceInstance process in test-broker.
test-broker controller contains few services, some of them are not deprovision asynchronous, it means they achieve this condition.

The are two problems: first deprovisionAttempts field of testServiceInstance is not increase anywhere so it means condition will be always true. Second, if condition is true then status code 0 is passed to NewErrorWithHTTPStatus method which causes panic.

Additionally, PR changes DeprovisionFailTimes (to 0) field for two services thanks to which they are removed immediately.

Please leave this checklist in the PR comment so that maintainers can ensure a good PR.

Merge Checklist:

• New feature
  • Tests
  • Documentation
• SVCat CLI flag
• Server Flag for config
  • Chart changes
  • removing a flag by marking deprecated and hiding to avoid
    breaking the chart release and existing clients who provide a
    flag that will get an error when they try to update

[k8s-ci-robot]

Welcome @jasiu001!

It looks like this is your first PR to kubernetes-sigs/service-catalog 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/service-catalog has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @jasiu001. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mszostok]

/ok-to-test

[mszostok]

that needs to be fixed in code,

if you set DeprovisionFailTimes to 0 then it should not fail at all. In your case you will have one fail and only the second call will be successful.

so basically this:

if instance.deprovisionAttempts <= service.DeprovisionFailTimes {

should be changed to:

if service.DeprovisionFailTimes > 0 && instance.deprovisionAttempts < service.DeprovisionFailTimes {

[mszostok]

@jasiu001 you need to execute the go fmt

[mszostok]

/test pull-service-catalog-xbuild

[mszostok]

/lgtm

[jberkhahn]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasiu001, jberkhahn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jberkhahn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment