This repository has been archived by the owner on May 6, 2022. It is now read-only.
Make svcat provision support namespaced resources #2618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
jberkhahn
force-pushed
the
namespace_provision2
branch
from
f34532d
to
1c22c8a
Compare
MHBauer
approved these changes
Apr 29, 2019
| PlanReference: v1beta1.PlanReference{ | ||
| ClusterServiceClassExternalName: className, | ||
| ClusterServicePlanExternalName: planName, | ||
| func (sdk *SDK) Provision(instanceName, classKubeName, planKubeName string, provisionClusterInstance bool, opts *ProvisionOptions) (*v1beta1.ServiceInstance, error) { |
There was a problem hiding this comment.
this function changed because of the mentioned comment I'd like added.
It's always kube names that come in now.
k8s-ci-robot
added
do-not-merge/hold
jberkhahn
force-pushed
the
namespace_provision2
branch
from
1c22c8a
to
1d7b79e
Compare
jberkhahn
removed
the
do-not-merge/hold
taragu
reviewed
May 3, 2019
| @@ -26,24 +27,29 @@ import ( | |||
| "github.com/spf13/cobra" | |||
| ) | |||
|
|
|||
| type provisonCmd struct { | |||
| // ProvisionCmd contains the info needed to provision a new service instance | |||
| type ProvisionCmd struct { | |||
There was a problem hiding this comment.
Why do we need to make ProvisionCmd public?
There was a problem hiding this comment.
I completely refactored the testing here. As part of that, I moved the tests into their own package, as per Ginkgo guidelines. So, I had to export the struct type and it's fields.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jboyd01 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
jberkhahn
force-pushed
the
namespace_provision2
branch
from
1d7b79e
to
22f2416
Compare
k8s-ci-robot
added
size/XXL
- add unit tests for provision_cmd.go - refactor provision_cmd.go to support new tests - fix typo ProvisonCmd -> ProvisionCmd
jberkhahn
force-pushed
the
namespace_provision2
branch
from
22f2416
to
4259f5c
Compare
|
/test pull-service-catalog-xbuild |
1 similar comment
|
/test pull-service-catalog-xbuild |
|
/lgtm |
3 tasks
viviyww
pushed a commit
to viviyww/service-catalog
that referenced
this pull request
Jun 20, 2019
…#2618) - add unit tests for provision_cmd.go - refactor provision_cmd.go to support new tests - fix typo ProvisonCmd -> ProvisionCmd
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the deleted goldenfile test was removed because the first call to the backend isn't a namespaced as it tries to locate exactly which cluster/namespaced service/plane the user is referring to. Thus, it no longer made sense in the current test frameworks. The args to the pkg lib (including the namespace) are tested in the newly added unit test for provision.go
Fixes #2371