This repository has been archived by the owner on May 6, 2022. It is now read-only.
Use 2 resources instead of a list #2608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See kubernetes-retired#2603 for more details, but - the indented, while supported today, isn't 100% kosher - it's a bit odd to use a list, so while legal we should do what most people expect and do, just create two separate resources Closes: kubernetes-retired#2603 Signed-off-by: Doug Davis <[email protected]>
k8s-ci-robot
added
cncf-cla: yes
|
ping @kramvan1 |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MHBauer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
viviyww
pushed a commit
to viviyww/service-catalog
that referenced
this pull request
May 10, 2019
See kubernetes-retired#2603 for more details, but - the indented, while supported today, isn't 100% kosher - it's a bit odd to use a list, so while legal we should do what most people expect and do, just create two separate resources Closes: kubernetes-retired#2603 Signed-off-by: Doug Davis <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2603 for more details, but
expect and do, just create two separate resources
Closes: #2603
Signed-off-by: Doug Davis [email protected]