reposition left menu (docs ToC) & make sure it doesn't overlap with other components #2574
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @arief-hidayat. Thanks for your PR. I'm waiting for a kubernetes-incubator or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
|
/assign @jberkhahn |
docsite/js/script.js
Outdated
| @@ -1,7 +1,7 @@ | |||
| //modal close button | |||
| (function(){ | |||
| //π.modalCloseButton = function(closingFunction){ | |||
| // return π.button('pi-modal-close-button', null, null, closingFunction); | |||
| // return π.button('pi-modal-close-button', null, null, closingFunction); | |||
| //}; | |||
There was a problem hiding this comment.
This is all commented out? Can we drop it?
There was a problem hiding this comment.
It's actually not related to my change.
But I think it's better to remove those commented lines.
There was a problem hiding this comment.
I have removed it. thanks
|
/ok-to-test /lgtm |
k8s-ci-robot
added
ok-to-test
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jberkhahn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
maybe we needed that, now it looks funny
|
|
My bad. I accidentally included other change in the commit. I'll raise new PR to revert it. |
…ther components (kubernetes-retired#2574) * reposition left menu (docs ToC) * remove commented lines
This PR is a
What this PR does / why we need it:
Which issue(s) this PR fixes
Fixes #2352
Please leave this checklist in the PR comment so that maintainers can ensure a good PR.
Merge Checklist:
breaking the chart release and existing clients who provide a
flag that will get an error when they try to update