-
Notifications
You must be signed in to change notification settings - Fork 382
Add Context object to Bind requests (OSBAPI) #2287
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Nice catch! Thank you for plumbing in the context for bindings. 👍
@carolynvs I've signed the CLA, but for whatever reason the respective CLA check doesn't pass. Any suggestions? Update: Scratch that. The moment I made the comment, the CLA check passed! :) |
/assign @MHBauer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NickyMateev Thanks for taking this on.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MHBauer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add Context object to Bind requests
This pull request addresses the issue where a bind operation for a specific service instance does not include the Context object (as specified in the OSBAPI spec) in the request to the broker.
The change was fairly simple and required to add similar logic like the one in controller_instange.go to controller_binding.go.
Old tests have been fixed.
Closes: #2283