This repository has been archived by the owner on May 6, 2022. It is now read-only.
remove from travis integration-tests which are now running in prow #2237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/XS
|
Shouldn't we also remove |
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
@jboyd01 my gut says it provides a quick enough signal that things are bad that we should leave it in for now. |
|
I am going to add a comment that says why what's in that list is in it. |
|
Yeah, sure, it's so quick in comparison to any tests we run, I'm all for it. Thanks for the details. |
k8s-ci-robot
added
lgtm
jboyd01
added
LGTM1
and removed
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carolynvs, jboyd01 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
itests in prow take ~30minutes
We need to make the integration tests create only one set of certificates and reuse them for the whole run.