Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Refactored pkg/svcat/kube/kube.go to pkg/util/kube/kube.go #2235

Conversation

Bubblemelon
Copy link
Contributor

This is in reference to issue #2183 :

Moved kube.go to new path pkg/util/kube
Tested the new import by building svcat.

Tried to install svcat on a local cluster using this installation guide: https://github.com/kubernetes-incubator/service-catalog/blob/master/docs/install.md

However, an error was returned when running Step 2:

helm install svc-cat/catalog \
    --name catalog --namespace catalog
Error: Get http://localhost:8080/api/v1/namespaces/kube-system/pods?labelSelector=app%3Dhelm%2Cname%3Dtiller: dial tcp [::1]:8080: connect: connection refused 

So was unable to test my scvat changes on a local cluster and use e2e tests.

Will try to get the installation running in a VM next.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 25, 2018
@jberkhahn
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 25, 2018
@MHBauer
Copy link
Contributor

MHBauer commented Jul 25, 2018

Looks like something bad happened. Generators blew up, and all of that client code should not have been removed.

@Bubblemelon Bubblemelon force-pushed the refactor-kubeconfig-loader-patch branch from 99f1e75 to 7f85b12 Compare July 25, 2018 21:08
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 25, 2018
@Bubblemelon Bubblemelon reopened this Jul 25, 2018
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 25, 2018
@Bubblemelon Bubblemelon force-pushed the refactor-kubeconfig-loader-patch branch from 21d6b44 to 56d340b Compare July 25, 2018 21:25
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 25, 2018
@MHBauer
Copy link
Contributor

MHBauer commented Jul 25, 2018

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MHBauer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2018
@jberkhahn
Copy link
Contributor

/lgtm

@jberkhahn jberkhahn merged commit 44847da into kubernetes-retired:master Jul 25, 2018
@MHBauer
Copy link
Contributor

MHBauer commented Jul 25, 2018

oh, manual merge

@Bubblemelon Bubblemelon deleted the refactor-kubeconfig-loader-patch branch July 27, 2018 23:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. LGTM1 LGTM2 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants