This repository has been archived by the owner on May 6, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 382
Refactored pkg/svcat/kube/kube.go
to pkg/util/kube/kube.go
#2235
Merged
jberkhahn
merged 1 commit into
kubernetes-retired:master
from
Bubblemelon:refactor-kubeconfig-loader-patch
Jul 25, 2018
Merged
Refactored pkg/svcat/kube/kube.go
to pkg/util/kube/kube.go
#2235
jberkhahn
merged 1 commit into
kubernetes-retired:master
from
Bubblemelon:refactor-kubeconfig-loader-patch
Jul 25, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
needs-ok-to-test
Indicates a PR that requires an org member to verify it is safe to test.
labels
Jul 25, 2018
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
Indicates a PR that requires an org member to verify it is safe to test.
label
Jul 25, 2018
Looks like something bad happened. Generators blew up, and all of that client code should not have been removed. |
Bubblemelon
force-pushed
the
refactor-kubeconfig-loader-patch
branch
from
July 25, 2018 21:08
99f1e75
to
7f85b12
Compare
k8s-ci-robot
added
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
and removed
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
labels
Jul 25, 2018
k8s-ci-robot
added
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
and removed
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
labels
Jul 25, 2018
Bubblemelon
force-pushed
the
refactor-kubeconfig-loader-patch
branch
from
July 25, 2018 21:25
21d6b44
to
56d340b
Compare
k8s-ci-robot
added
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
and removed
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
labels
Jul 25, 2018
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MHBauer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Jul 25, 2018
/lgtm |
oh, manual merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in reference to issue #2183 :
Moved
kube.go
to new pathpkg/util/kube
Tested the new import by building svcat.
Tried to install svcat on a local cluster using this installation guide: https://github.com/kubernetes-incubator/service-catalog/blob/master/docs/install.md
However, an error was returned when running Step 2:
So was unable to test my scvat changes on a local cluster and use e2e tests.
Will try to get the installation running in a VM next.