This repository has been archived by the owner on May 6, 2022. It is now read-only.
Test svcat gracefully handles the ns-broker flag being disabled #2234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
size/M
carolynvs
force-pushed
the
do-not-assume-ns-brokers-enabled
branch
from
b4c570b
to
c1d2033
Compare
carolynvs
requested review from
jberkhahn and
duglin
and removed request for
n3wscott
carolynvs
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
carolynvs
requested review from
jeremyrickard
and removed request for
kikisdeliveryservice
jeremyrickard
approved these changes
Jul 25, 2018
| ) | ||
|
|
||
| var catalogRequestRegex = regexp.MustCompile("/apis/servicecatalog.k8s.io/v1beta1/(.*)") | ||
| var coreRequestRegex = regexp.MustCompile("/api/v1/(.*)") | ||
|
|
||
| // Verify that svcat gracefully handles when the namespaced broker feature flag is disabled | ||
| // TODO: Once we take Namespaced brokers out from behind the feature flag, this test won't be necessary |
There was a problem hiding this comment.
probably once we get it out from the feature flag + some number of versions?
There was a problem hiding this comment.
Yeah I think you are right, I'm just not sure how long yet. Maybe until 1.0 honestly...
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: duglin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
svcatwill need to gracefully handle interacting with servers that have the feature flag for namespaced broker resources disabled.svcat describe broker --namespace NS NAME, I believe that should be a real error. Since that wasn't a supported command before. When we add support for those, we'll add test cases to ensure the proper error behavior.We'll probably want to keep this around for at least until the feature flag is removed, perhaps longer so that people don't need to be careful about which client version they use with a particular version of the api server.