Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

test storages to make sure they are appropriate types #2161

Merged
merged 5 commits into from
Jul 24, 2018
Merged

test storages to make sure they are appropriate types #2161

merged 5 commits into from
Jul 24, 2018

Conversation

MHBauer
Copy link
Contributor

@MHBauer MHBauer commented Jun 27, 2018

more "test some stuff so things don't break when I change other stuff" tests

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 27, 2018
@MHBauer
Copy link
Contributor Author

MHBauer commented Jul 3, 2018

/retest

@jberkhahn
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2018
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 17, 2018
@jberkhahn
Copy link
Contributor

I would switch the Ω to Expects and then this looks good to me.

@MHBauer
Copy link
Contributor Author

MHBauer commented Jul 19, 2018

took out the unicode expects

@jberkhahn
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2018
@MHBauer
Copy link
Contributor Author

MHBauer commented Jul 19, 2018

/assign @carolynvs

@MHBauer MHBauer added the LGTM1 label Jul 24, 2018
MHBauer
MHBauer commented Jul 24, 2018
View reviewed changes
Copy link
Contributor Author

@MHBauer MHBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MHBauer
Copy link
Contributor Author

MHBauer commented Jul 24, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MHBauer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2018
@MHBauer MHBauer added the LGTM2 label Jul 24, 2018
@MHBauer
Copy link
Contributor Author

MHBauer commented Jul 24, 2018

/retest

@k8s-ci-robot k8s-ci-robot merged commit f827e3b into kubernetes-retired:master Jul 24, 2018
@MHBauer MHBauer deleted the more-storage-testing branch July 24, 2018 05:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpeeler jpeeler Awaiting requested review from jpeeler

@nilebox nilebox Awaiting requested review from nilebox

Assignees

@carolynvs carolynvs

@jberkhahn jberkhahn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. LGTM1 LGTM2 size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MHBauer @jberkhahn @k8s-ci-robot @carolynvs