Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Vet fixes #2160

Merged
merged 4 commits into from
Jul 2, 2018
Merged

Vet fixes #2160

merged 4 commits into from
Jul 2, 2018

Conversation

MHBauer
Copy link
Contributor

@MHBauer MHBauer commented Jun 27, 2018

doing some compiling and got some vet responses.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 27, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mhbauer

Assign the PR to them by writing /assign @mhbauer in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MHBauer
Copy link
Contributor Author

MHBauer commented Jun 27, 2018

I see, pointer to string can be nil. Reevaluating.

@MHBauer
Copy link
Contributor Author

MHBauer commented Jun 27, 2018

will fix with a nil check, filed kubernetes-retired/go-open-service-broker-client#123 to consider upstream printers.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 27, 2018
@duglin
Copy link
Contributor

duglin commented Jul 2, 2018

LGTM

@duglin duglin added the LGTM1 label Jul 2, 2018
@jboyd01 jboyd01 added the LGTM2 label Jul 2, 2018
@jboyd01 jboyd01 merged commit 2370714 into kubernetes-retired:master Jul 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. LGTM1 LGTM2 size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants