Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

use the built integration.test binary #2154

Merged
merged 1 commit into from
Jun 26, 2018
Merged

use the built integration.test binary #2154

merged 1 commit into from
Jun 26, 2018

Conversation

MHBauer
Copy link
Contributor

@MHBauer MHBauer commented Jun 23, 2018

as part of invoking make test we build the test,
as part of running the test we build the test again.

if you could build the test the first time, why would this change, so just use the existing output.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: arschles

Assign the PR to them by writing /assign @arschles in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 23, 2018
@jberkhahn
Copy link
Contributor

Seems reasonable. However, looking back it seems we used to do a bit of custom set up inside integration.sh. Is that uncessessary now and in the future?

@MHBauer
Copy link
Contributor Author

MHBauer commented Jun 25, 2018

the build-integration target is always called, and it skips all of the details of integration.sh, and nobody has complained so far, so I figured it was okay to dump it.

Copy link
Contributor

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpeeler
Copy link

jpeeler commented Jun 26, 2018

The -i flag was my concern in the wrapper script and since that's not being used, this change LGTM.

@jpeeler jpeeler added the LGTM2 label Jun 26, 2018
@jpeeler jpeeler merged commit 3009943 into kubernetes-retired:master Jun 26, 2018
@MHBauer MHBauer deleted the itest-cleanup branch June 26, 2018 23:32
kikisdeliveryservice pushed a commit to kikisdeliveryservice/service-catalog that referenced this pull request Jun 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. LGTM1 LGTM2 size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants