Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Disable flakey test #2143

Merged
merged 1 commit into from
Jun 21, 2018
Merged

Conversation

carolynvs
Copy link
Contributor

Anyone who has time to investigate is more than welcome, but this test has stolen enough time from me that I can't take it anymore

The flake is being tracked under #2036.

Anyone who has time to investigate is more than welcome, but this test has stolen enough time from me that I can't take it anymore

kubernetes-retired#2036
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 21, 2018
@eriknelson
Copy link
Contributor

+1

Copy link
Contributor

@MHBauer MHBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this. Will save some build time, too.

LGTM

But in theory, if it's so painful, we'd focus on making a fix. Either a merge freeze, or blah blah.

@MHBauer MHBauer added the LGTM1 label Jun 21, 2018
@MHBauer MHBauer requested review from jpeeler and staebler June 21, 2018 15:53
@carolynvs
Copy link
Contributor Author

Depends on whose feeling the pain and if they are in a position to fix it. 🤷‍♀️ I'm not familiar with that code, have a ton on my plate, and it's making it harder for me to help people with their PRs. So yeah I'm feeling the pain, but am not sure how to fix (beyond what I've done already to track the flake).

Copy link
Contributor

@arschles arschles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good with me. Thanks for referencing the issue to track it!

LGTM

@arschles arschles merged commit d21da40 into kubernetes-retired:master Jun 21, 2018
kikisdeliveryservice pushed a commit to kikisdeliveryservice/service-catalog that referenced this pull request Jun 29, 2018
Anyone who has time to investigate is more than welcome, but this test has stolen enough time from me that I can't take it anymore

kubernetes-retired#2036
@carolynvs carolynvs deleted the disable-test-flake branch October 4, 2018 21:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. LGTM1 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants