This repository has been archived by the owner on May 6, 2022. It is now read-only.
reenable the controller default relist interval #2125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/M
- dump apiserver defaults + validation - dump checks in controller for a set value
carolynvs
reviewed
Jun 21, 2018
| ) | ||
| } | ||
|
|
||
| if spec.RelistBehavior == sc.ServiceBrokerRelistBehaviorManual && spec.RelistDuration != nil { |
There was a problem hiding this comment.
What's the defined behavior for a manual relist? I don't quite understand why your change makes it okay to say manual and set a duration.
There was a problem hiding this comment.
Manual is "only respond to an increase in the relist-requests, no automated pinging of the broker"
My opinion is that this causes unecessary friction if switching from duration to manual, and that while it doesn't make much sense to explicitly specify manual and duration, it shouldn't be a hard error. Manual should override everything else.
There was a problem hiding this comment.
Ah, that makes sense thanks! 👍
|
LGTM |
kikisdeliveryservice
pushed a commit
to kikisdeliveryservice/service-catalog
that referenced
this pull request
Jun 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2119
/cc @duglin
/assign @duglin