This repository has been archived by the owner on May 6, 2022. It is now read-only.
Bring back root CA certificates to a Service Catalog Docker image #2071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
@nilebox The build error does look related to your change, can you take a look? |
|
@carolynvs was some flaky failure in Travis, retry helped |
|
kicked it, seems okay now. |
MHBauer
approved these changes
May 25, 2018
|
@carolynvs thinking that you forgot to add LGTM label, I merged the PR. |
|
I think maybe did not add tag because build was not green at the time. |
|
Correct, I wasn't sure if the build failure was related or a flake. 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #2003 that changed base Docker image from Debian to scratch has also removed root CA certificates from it (see https://github.com/kubernetes-incubator/service-catalog/pull/2003/files#diff-e355acdaa4066a6dea138158e98252fbL19).
This change brings them back via Docker multi-stage build.
/cc @MHBauer @jboyd01