This repository has been archived by the owner on May 6, 2022. It is now read-only.
Tests for filter.go and comments in types.go #2055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
n3wscott
reviewed
May 21, 2018
| @@ -1314,9 +1316,9 @@ const ( | |||
| // SpecServiceBrokerName is used for ServiceClasses, the parent service broker name. | |||
| FilterSpecServiceBrokerName = "spec.serviceBrokerName" | |||
| // SpecClusterServiceClassName is only used for plans, the parent service class name. | |||
| FilterSpecClusterServiceClassName = "spec.clusterServiceClass.name" | |||
| // name - the value set to [Cluster]ServicePlan.Name | ||
| // spec.externalName - the value set to [Cluster]ServicePlan.Spec.ExternalName | ||
| // spec.externalID - the value set to [Cluster]ServicePlan.Spec.ExternalID | ||
| // spec.serviceClassName - the value set to [Cluster]ServicePlan.Spec.ServiceClassRef.Name |
There was a problem hiding this comment.
Please change this line to:
// spec.serviceClass.name - the value set to ServicePlan.Spec.ServiceClassRef.Name
// spec.clusterServiceClass.name - the value set to ClusterServicePlan.Spec.ClusterServiceClassRef.Name
| // SpecServiceClassName is only used for plans, the parent service class name. | ||
| FilterSpecServiceClassName = "spec.serviceClass.name" |
pkg/apis/servicecatalog/types.go
Outdated
| // name - the value set to [Cluster]ServicePlan.Name | ||
| // spec.externalName - the value set to [Cluster]ServicePlan.Spec.ExternalName | ||
| // spec.externalID - the value set to [Cluster]ServicePlan.Spec.ExternalID | ||
| // spec.serviceClassName - the value set to [Cluster]ServicePlan.Spec.ServiceClassRef.Name |
There was a problem hiding this comment.
Same comments apply to here from the other types file
added 2 commits
May 21, 2018 16:19
|
@carolynvs put on those kicking boots please, this build needs a kick. (Relates to #2036) |
|
Kicked! |
carolynvs
approved these changes
May 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally closed my PR... long story, But here it is again with a fix for scotts comment