This repository has been archived by the owner on May 6, 2022. It is now read-only.
Add make test-update-goldenfiles target #2045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
@teaguecole let me know if this matches what you were expecting! |
|
Yeah, this is great! I was just expecting a more official go doc about golden files as opposed to just a medium blog post... but to integrate it with make is awesome and consistent. |
|
Oh yeah I don't have anything official. I just know that they use it in the go stdlib tests themselves, and I have used that pattern in other repos, like golang/dep. |
MHBauer
approved these changes
May 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-on for #2041 (comment).
Add a new make target
test-update-goldenfilesthat runs the svcat tests and updates the golden files and document it in the devguide.Doc preview available at: https://deploy-preview-2045--svc-cat.netlify.com/docs/devguide/#golden-files