Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

cluster-info configmap role namespace issues #2042

Merged
merged 1 commit into from
May 23, 2018

Conversation

jboyd01
Copy link
Contributor

@jboyd01 jboyd01 commented May 16, 2018

closes #1973
The role's namespace was "default", should be "catalog". Also need to specify the namespace to use for the configmap as an argument for the controller.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 16, 2018
@jboyd01 jboyd01 requested a review from MHBauer May 17, 2018 20:35
Copy link
Contributor

@MHBauer MHBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MHBauer MHBauer added the LGTM1 label May 21, 2018
Copy link
Contributor

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carolynvs carolynvs merged commit 97e9780 into kubernetes-retired:master May 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. LGTM1 LGTM2 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading message in logs: error getting the cluster info configmap
4 participants