-
Notifications
You must be signed in to change notification settings - Fork 382
Conversation
CURDIR is guaranteed to be there by Make.
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Just had my primary github email set to my personal one. I think it should be fine now (assuming that this comment redoes the CLA check, as hinted at by the bot). |
kicked travis to see if we can get under the build limit |
What is https://www.gnu.org/software/make/manual/make.html#index-CURDIR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very neat, learned another thing about make
LGTM
oh, derp, |
Thanks - I'm probably the only one who will be affected by this, but it tripped me up 3 months ago and I'd forgotten it when I went to poke Service Catalog again yesterday. |
Lgtm |
@wryun what shell are you running? |
https://wryun.github.io/es-shell/ (I didn't write it, just made a website) |
CURDIR is guaranteed to be there by Make.