Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Not all shells set PWD #2024

Merged
merged 1 commit into from
May 11, 2018
Merged

Not all shells set PWD #2024

merged 1 commit into from
May 11, 2018

Conversation

wryun
Copy link
Contributor

@wryun wryun commented May 9, 2018

CURDIR is guaranteed to be there by Make.

CURDIR is guaranteed to be there by Make.
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 9, 2018
@MHBauer
Copy link
Contributor

MHBauer commented May 10, 2018

@wryun I'm surprised you're not under the corporate cla for atlassian, we already have @nilebox and @ash2k

@wryun
Copy link
Contributor Author

wryun commented May 10, 2018

Just had my primary github email set to my personal one. I think it should be fine now (assuming that this comment redoes the CLA check, as hinted at by the bot).

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 10, 2018
@MHBauer
Copy link
Contributor

MHBauer commented May 11, 2018

kicked travis to see if we can get under the build limit

@MHBauer
Copy link
Contributor

MHBauer commented May 11, 2018

What is $(PWD)? Some convenience function for $(shell pwd)?

https://www.gnu.org/software/make/manual/make.html#index-CURDIR

Copy link
Contributor

@MHBauer MHBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very neat, learned another thing about make

LGTM

@MHBauer
Copy link
Contributor

MHBauer commented May 11, 2018

oh, derp, PWD is literally the environment variable

@wryun
Copy link
Contributor Author

wryun commented May 11, 2018

Thanks - I'm probably the only one who will be affected by this, but it tripped me up 3 months ago and I'd forgotten it when I went to poke Service Catalog again yesterday.

@duglin
Copy link
Contributor

duglin commented May 11, 2018

Lgtm

@duglin duglin merged commit 70e3b2a into kubernetes-retired:master May 11, 2018
@MHBauer
Copy link
Contributor

MHBauer commented May 11, 2018

@wryun what shell are you running?

@wryun
Copy link
Contributor Author

wryun commented May 12, 2018

https://wryun.github.io/es-shell/ (I didn't write it, just made a website)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants