This repository has been archived by the owner on May 6, 2022. It is now read-only.
don't require specifying a plan when creating an instance #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
carolynvs
approved these changes
May 8, 2018
|
Thanks for the review @carolynvs, I just wanted to be certain it wasn't intentional. |
|
We need to add a test that exercises this so that it doesn’t regress again
…On Tue, May 8, 2018 at 6:24 AM Jay Boyd ***@***.***> wrote:
Thanks for the review @carolynvs <https://github.com/carolynvs>, I just
wanted to be certain it wasn't intentional.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2016 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAWXmELDRkkQf8114XgqenYnwhW4HG_Dks5twZx0gaJpZM4TxWAK>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2015
We regressed functionality by enforcing that a plan is specified when an instance is provisioned. If no plan is specified, the default service plan admission controller will validate and assign the only plan that is associated with the specified class or it will return an error indicating there is no default plan.
@carolynvs could you please review and make sure you agree with this change? The validations were added in #1756