This repository has been archived by the owner on May 6, 2022. It is now read-only.
Renames the svcat --kube-context flag to --context (#1821) #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…netes-retired#1821) * simply renamed the string kube-context flag as context
k8s-ci-robot
added
size/M
carolynvs
suggested changes
Apr 27, 2018
cmd/svcat/main.go
Outdated
| @@ -112,7 +112,7 @@ func buildRootCommand(cxt *command.Context) *cobra.Command { | |||
| }, | |||
| } | |||
|
|
|||
| cmd.PersistentFlags().StringVar(&opts.KubeContext, "kube-context", "", "name of the kube context to use") | |||
| cmd.PersistentFlags().StringVar(&opts.KubeContext, "context", "", "name of the kubeconfig context to use. This replaces the flag --kube-context") | |||
There was a problem hiding this comment.
Since we are not to v1.0 yet, we don't need to put "This replaces the flag..." in the help text.
cmd/svcat/plugin/manifest.go
Outdated
| "log-flush-frequency": {}, | ||
| "logtostderr": {}, | ||
| "match-server-version": {}, | ||
| // "kube-context": {}, this now replaced with the flag "context" |
There was a problem hiding this comment.
This line can be deleted, nice catch!
|
Hi @carolynvs ! Thank you so much for all your help 😄 I've made the changes you've requested and it's in this 6aae4d7 commit, as listed above on this thread. |
carolynvs
approved these changes
Apr 27, 2018
MHBauer
approved these changes
Apr 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1821