Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Float docs TOC navbar when scrolling #1994

Merged
merged 1 commit into from
Apr 27, 2018

Conversation

carolynvs
Copy link
Contributor

@carolynvs carolynvs commented Apr 26, 2018

Some of the doc pages, like the walkthrough, have a navigation bar linking to the subheaders on the page. This changes that sidebar to float with you as you scroll, so that you don't have to jump back up to the top to navigate to another section in the page.

Preview available at https://deploy-preview-1994--svc-cat.netlify.com/docs/walkthrough/

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 26, 2018
@jberkhahn
Copy link
Contributor

Neat. Looks fine to me.

@jboyd01 jboyd01 added the LGTM1 label Apr 27, 2018
@jboyd01
Copy link
Contributor

jboyd01 commented Apr 27, 2018

Really nice & many thanks for the live preview link. LGTM

@n3wscott n3wscott added the LGTM2 label Apr 27, 2018
@n3wscott n3wscott merged commit 7776226 into kubernetes-retired:master Apr 27, 2018
@carolynvs carolynvs deleted the float-toc-navbar branch October 4, 2018 21:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. LGTM1 LGTM2 size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants