This repository has been archived by the owner on May 6, 2022. It is now read-only.
Only validate status on updates #1972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
This looks good. Interesting that we weren't already testing validateServiceBindingStatus() anywhere in the test. |
jpeeler
force-pushed
the
separate-status-update
branch
from
22152ab
to
1d7767b
Compare
k8s-ci-robot
added
size/S
jpeeler
force-pushed
the
separate-status-update
branch
from
1d7767b
to
599bde0
Compare
|
@n3wscott I think what I was missing was the fuzzer needed adjusting. You're probably a good person to look over this too once all this is green. |
This basically ensures that spec validations don't include status.
jpeeler
force-pushed
the
separate-status-update
branch
from
599bde0
to
049396a
Compare
k8s-ci-robot
added
size/XS
|
Was wrong about the fuzzer. |
jpeeler
changed the title
|
@jpeeler there's no fuzzer changes here. Are comments on the right PR? |
|
Yes, Jeff recut the PR not to introduce a new default. |
|
Jeff is out today, but we have been discussing this PR offline. He tested this by:
|
|
Everything Paul said is correct, this PR is ready to go. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically ensures that spec validations don't include status.
Closes #1960