This repository has been archived by the owner on May 6, 2022. It is now read-only.
Add feature flag for making instance/binding locks optional #1917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
This was referenced Apr 5, 2018
MHBauer
approved these changes
Apr 12, 2018
pkg/features/features.go
Outdated
| AsyncBindingOperations: {Default: false, PreRelease: utilfeature.Alpha}, | ||
| NamespacedServiceBroker: {Default: false, PreRelease: utilfeature.Alpha}, | ||
| ResponseSchema: {Default: false, PreRelease: utilfeature.Alpha}, | ||
| OriginatingIdentityLocking: {Default: true, PreRelease: utilfeature.Alpha}, |
There was a problem hiding this comment.
@duglin I think this is set up the way we want.
duglin
reviewed
Apr 13, 2018
| // If the OriginatingIdentityLocking feature is set then don't allow spec updates | ||
| // if processing of the current generation hasn't finished yet | ||
| if utilfeature.DefaultFeatureGate.Enabled(scfeatures.OriginatingIdentityLocking) { | ||
| if old.Generation != new.Generation && old.Status.ReconciledGeneration != old.Generation { |
There was a problem hiding this comment.
Can we get this changed so that it allow the request go go thru when its the same user? And the other check below too?
There was a problem hiding this comment.
I don't want to change the behavior in this PR, your change should be a follow-up to this one.
|
rebase needed |
|
rebased, conflict was on feature gates between adding url update and adding this flag. |
|
LGTM once tests pass |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracting introduction of the new feature flag from #1872 to make reviews easier through small iterative PRs.