This repository has been archived by the owner on May 6, 2022. It is now read-only.
Allow retries for instances with Failed condition after spec changes #1751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/M
nilebox
commented
Feb 26, 2018
| @@ -110,7 +110,7 @@ func withConfigGetFreshApiserverAndClient( | |||
|
|
|||
| if err := server.RunServer(options, stopCh); err != nil { | |||
| close(serverFailed) | |||
| t.Fatalf("Error in bringing up the server: %v", err) | |||
| t.Logf("Error in bringing up the server: %v", err) | |||
There was a problem hiding this comment.
see golang/go#15976
The integration test was failing with data race
|
This needs to wait on #1748, right? Otherwise, if the user tries to update an instance that failed to provision, then the controller will attempt to send an update request to the broker, instead of a provision request. |
@kibbles-n-bytes yes, you're right, I do this in #1748 |
|
The only issue with allowing retries for instances with See #1771 (comment) |
|
LGTM |
staebler
approved these changes
Mar 6, 2018
jeremyrickard
pushed a commit
to jeremyrickard/service-catalog
that referenced
this pull request
Mar 13, 2018
…ubernetes-retired#1751) * Allow retries for instances with Failed condition after spec changes * Remove Fatalf from server startup goroutine to fix data race
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of item number
2.from the checklist #1715 (comment)After this change we should be able to retry after receiving
400 Bad Requestfrom broker as soon as we change the spec.