This repository has been archived by the owner on May 6, 2022. It is now read-only.
Workaround spf13/viper stringarray bug #1700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split up validation and command execution so that we can test them separately
Switching from StringArray to StringSlice to workaround spf13/viper#398.
k8s-ci-robot
added
cncf-cla: yes
|
@jberkhahn Any opinion? |
|
@carolynvs does the new testing catch the bug as it would have been? |
|
I haven't dug into the Cobra stuff yet, so I can't comment on this. I will echo Morgan though, would like a test that shows this is fixed. |
|
The very first commit added a failing test. The second fixes it and the third commit added arg validation tests for the other commands. |
MHBauer
approved these changes
Feb 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1699.
Let me know if you'd prefer that the last commit in this PR (which refactors the remaining commands to be testable), should be split into a separate PR.