The controller does not refresh auth data from a secret

[piotrmiskiewicz]

Bug Report

What happened:

The controller does not refresh secret with authorization data (for example basic auth). This may cause an error, when the secret with credentials is changing, for example in GCP broker

What you expected to happen:

Every time the secret with auth is changed, the controller creates new OSB Client instance

How to reproduce it (as minimally and precisely as possible):

Install service broker with basic auth stored in a secret. Provide wrong credentials, then update the secret with valid credentials. Service Catalog still cannot fetch the catalog.

[piotrmiskiewicz]

The osb client is updated only in broker reconcile method, see:
https://github.com/kubernetes-incubator/service-catalog/blob/master/pkg/controller/controller_servicebroker.go#L154