Improve caching OSB clients

[piotrmiskiewicz]

This PR is a

• Feature Implementation
• Bug Fix
• Documentation

What this PR does / why we need it:
The idea of caching OSB clients was changed:

1. New client instance is created when it is not present in the cache
2. Secret with Auth data is alway fetched (from informer cache) - so there is no risk the auth data is outdated. If the auth data has beed changed - new OSB client will be created

Which issue(s) this PR fixes
Fixes #2576
Fixes #2563

Please leave this checklist in the PR comment so that maintainers can ensure a good PR.

Merge Checklist:

• New feature
  • Tests
  • Documentation
• SVCat CLI flag
• Server Flag for config
  • Chart changes
  • removing a flag by marking deprecated and hiding to avoid
    breaking the chart release and existing clients who provide a
    flag that will get an error when they try to update

[k8s-ci-robot]

Hi @piotrmiskiewicz. Thanks for your PR.

I'm waiting for a kubernetes-incubator or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jboyd01]

looks good, add an error check and I think you are good to go.

[jboyd01]

check for non-nil err after this

[piotrmiskiewicz]

you are right, the check is missing, added

[jboyd01]

Thanks @piotrmiskiewicz!
/approve
/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jboyd01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jboyd01]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jberkhahn]

Do you think it would be possible add a new test to replace the one removed in controller_servicebroker_test.go? Something to test the new client fetching the auth info?

[piotrmiskiewicz]

Hi, I'm planning rewrite integration tests as a part of switching to CRDs. The PR is not yet prepared, but I have a controller test which covers the scenario. I've just cherry-picked the commit to the branch with refreshing auth info and I've created a branch to show you how it will looks like. The test is passing, see: https://github.com/piotrmiskiewicz/service-catalog/blob/osb-test/test/controller/flow_test.go#L13

You can see there:

1. create a secret with some username and password
2. all calls to osb client makes the last auth saved (then it can be verified)
3. there are asserts, which verifies the last auth used (method AssertOSBBasicAuth)

[piotrmiskiewicz]

I realized the test TestReconcileServiceBrokerUpdatesBrokerClient still can work, I've restored it.

[jberkhahn]

/lgtm

[jberkhahn]

Hmm, the git robot didn't assign the issue to me when i commented on Friday. Weird.