fix and todo

kubernetes-retired · Sep 20, 2017 · 4546769 · 4546769
1 parent 7193ec2
commit 4546769
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/Makefile b/Makefile
@@ -110,7 +110,7 @@ NON_VENDOR_DIRS = $(shell $(DOCKER_CMD) glide nv)
 build: .init .generate_files \
 	$(BINDIR)/apiserver \
 	$(BINDIR)/controller-manager \
-	$(BINDIR)/user-broker
+	$(BINDIR)/user-broker \
 	plugins
 
 user-broker: $(BINDIR)/user-broker

diff --git a/plugin/cmd/kubectl/utils/utils.go b/plugin/cmd/kubectl/utils/utils.go
@@ -40,6 +40,10 @@ func CheckNamespaceExists(name string) error {
 	proxyURL := "http://127.0.0.1"
 	proxyPort := "8881"
 
+	// TODO: use the KUBECTL_PLUGINS_CALLER env var, which will
+	// give you the full path to the kubectl binary.
+	//
+	// https://github.com/kubernetes-incubator/service-catalog/pull/840/files#r120732815
 	kubeProxy := exec.Command("kubectl", "proxy", "-p", proxyPort)
 	defer func() {
 		if err := kubeProxy.Process.Kill(); err != nil {