This repository has been archived by the owner on Dec 22, 2018. It is now read-only.
Patch Ganesha to use device number as fsid for overlayfs #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
wongma7
changed the title
|
Tested working (read/write to shares) with overlay, overlay2, devicemapper. Also did as thorough a look as I could through ganesha that this doesn't break anything. Based on the ability to configure what type of fsid to use https://github.com/nfs-ganesha/nfs-ganesha/blob/next/src/config_samples/config.txt#L348, including device #, I believe this is safe. The problem with using that config option is, it only re-indexes existing "fs-fsid"s, so if the fs-fsid was discarded from the beginning it won't help. |
wongma7
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/kubernetes-incubator/nfs-provisioner/issues/60
Still need to test this doesn't break anything. appears to work fine with overlayfs & devicemapper storage drivers. Opened nfs-ganesha/nfs-ganesha#140 to ask for help.