This repository has been archived by the owner on Dec 22, 2018. It is now read-only.
Adds claim to the Provision(..) call #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
childsb
commented
Dec 29, 2016
| @@ -267,7 +267,7 @@ func (p *nfsProvisioner) validateOptions(options controller.VolumeOptions) (stri | |||
| return "", fmt.Errorf("error calling statfs on %v: %v", p.exportDir, err) | |||
| } | |||
| capacity := options.Capacity.Value() | |||
| available := int64(stat.Bavail) * stat.Bsize | |||
There was a problem hiding this comment.
This was causing a build error for me
|
Can you make it part of the VolumeOptions struct? https://github.com/kubernetes-incubator/nfs-provisioner/blob/master/controller/volume.go#L56 . Then we can make it look like upstream https://github.com/kubernetes/kubernetes/blob/f49442d4331052c3141c47a3f9701da7082ebcff/pkg/volume/plugins.go#L51 Thanks |
|
done in #48 ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review..
Adding the users claim to Provision(..) ..
Will be used if annotations on the users claim are required to provision (example: user owned secrets).
Also updated the .gitignore to remove intellij garbage.