-
Notifications
You must be signed in to change notification settings - Fork 173
Create HierarchicalNamespace CRD #448
Create HierarchicalNamespace CRD #448
Conversation
This comment has been minimized.
This comment has been minimized.
incubator/hnc/config/crd/bases/hnc.x-k8s.io_hierarchyconfigurations.yaml
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
8a39dbb
to
4b5ab13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm after one last change
253fb42
to
4b0bd4e
Compare
lgtm. Can you confirm that if you just say |
/assign @rjbez17 |
/hold For Ryan to review. |
This comment has been minimized.
This comment has been minimized.
This CRD is created as the UX of the HNC self-service namespace. See design at http://bit.ly/hnc-self-serve-ux. Tested on a GKE cluster by "kubectl apply -f" the generated CRD yaml file. The CRD was created with success. I also added a sample hns.yaml and ran "kubectl create -f", the hns object was created and showed up when I ran "kubectl get hns". The possibility of "kubectl create hns" is still under investigation, since the "kubectl create" only supports a selected list of built-in resource types (even "kubectl create pod" is not supported). We will see if "kubectl create" a CR object is possible.
4b0bd4e
to
1198263
Compare
I added a sample hns.yaml for It's a |
/assign @sophieliu15 |
@yiqigao217: GitHub didn't allow me to assign the following users: sophieliu15. Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Ok, pity that we can't do /shrug I'm ok with this one @rjbez17 is. I think he's OOO today so perhaps he'll reply tomorrow, if not lmk and I'll approve this myself. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin, rjbez17, yiqigao217 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This CRD is created as the UX of the HNC self-service namespace. See
design at http://bit.ly/hnc-self-serve-ux.
Tested on a GKE cluster by "kubectl apply -f" the generated CRD yaml
file. The CRD was created with success. I also added a sample hns.yaml
and ran "kubectl create -f", the hns object was created and showed up
when I ran "kubectl get hns".
The possibility of "kubectl create hns" is still under investigation,
since the "kubectl create" only supports a selected list of built-in
resource types (even "kubectl create pod" is not supported). We will see
if "kubectl create" a CR object is possible.
Part of #457