This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
Exclude kube-node-lease from HNC #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't allow subnamespaces or nontrivial hierarchies in kube-node-lease, just like it's not allowed in kube-system and a few others. Tested: without this change, can create a subns in kube-node-lease; with this change, I get the appropriate error message. Not adding an automated test for this since it would just duplicate the contents of the default_config.go file. All existing e2e tests pass.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/assign @yiqigao217 |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
yiqigao217
reviewed
Dec 2, 2020
No, AFAIK it's part of any base Kubernetes installation. I think it's used to keep track of the nodes themselves. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't allow subnamespaces or nontrivial hierarchies in
kube-node-lease, just like it's not allowed in kube-system and a few
others.
Tested: without this change, can create a subns in kube-node-lease; with
this change, I get the appropriate error message. Not adding an
automated test for this since it would just duplicate the contents of
the default_config.go file. All existing e2e tests pass.
Fixes #1229