HNC: support dry-run #1027
Comments
|
This should be easy enough to pull into 0.5.2. |
|
Hmm, this appears to be working for me. Not sure why. |
|
Not only can I create pods with dry-run, but also namespaces and |
|
Turns out I've been testing on 1.16, while this feature was only enabled in 1.18. I'll have another go tomorrow. |
|
Reproduced successfully |
|
Fixed with a simple kustomization patch |
See issue kubernetes-retired#1027. To support server-side dry-run, all admission webhooks must state that they do not have any side effects. Our version of controller-gen doesn't include the sideEffects marker so I added them as a kustomization patch. Tested: server-side dry-run fails on a pod creation in Kind 1.18 without this fix and passes with it. GKE doesn't have 1.18 yet so I couldn't test it there, but I also tested it on GKE 1.15 (the oldest currently supported version) to ensure that it had no ill effects, and all e2e tests work fine on both Kind 1.18 and GKE 1.15.
Cherry-pick from HNC v0.5 - commit ce98366. Tested: many e2e tests are currently broken on master (kubernetes-retired#1058) but the ones that are passing before this change also pass after it. Original commit message follows. --- See issue kubernetes-retired#1027. To support server-side dry-run, all admission webhooks must state that they do not have any side effects. Our version of controller-gen doesn't include the sideEffects marker so I added them as a kustomization patch. Tested: server-side dry-run fails on a pod creation in Kind 1.18 without this fix and passes with it. GKE doesn't have 1.18 yet so I couldn't test it there, but I also tested it on GKE 1.15 (the oldest currently supported version) to ensure that it had no ill effects, and all e2e tests work fine on both Kind 1.18 and GKE 1.15.
Cherry-pick from HNC v0.5 - commit ce98366. Tested: many e2e tests are currently broken on master (kubernetes-retired#1058) but roughly the same ones fail before and after (there appears to be a bit of flakiness) and I very much doubt any of the failures are caused by this change. Original commit message follows. --- See issue kubernetes-retired#1027. To support server-side dry-run, all admission webhooks must state that they do not have any side effects. Our version of controller-gen doesn't include the sideEffects marker so I added them as a kustomization patch. Tested: server-side dry-run fails on a pod creation in Kind 1.18 without this fix and passes with it. GKE doesn't have 1.18 yet so I couldn't test it there, but I also tested it on GKE 1.15 (the oldest currently supported version) to ensure that it had no ill effects, and all e2e tests work fine on both Kind 1.18 and GKE 1.15.
|
Fixed in 0.5.2 /close |
|
@adrianludwin: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Per a comment on Slack, when HNC is installed you can no longer run:
This is likely a webhook config problem.
Update Aug 26: requires K8s 1.18 (KIND is fine) and
--dry-run=serverThe text was updated successfully, but these errors were encountered: