-
Notifications
You must be signed in to change notification settings - Fork 530
Add pod level annotations #1468
Add pod level annotations #1468
Conversation
Bumped up the chart version of the controller manager Bumped up the dependency version Added a new annotation and left the existing one incase it breaks any other previous changes. But not sure if the previous one created was done correctly, so have left it intact.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @irfanurrehman |
/retest |
@nitinatgh: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irfanurrehman, makkes, nitinatgh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Added in description to the README.md
Bumped up the chart version of the controller manager
Bumped up the dependency version
Added a new annotation and left the existing one incase it breaks any other previous changes. But not sure if the previous one created was done correctly, so have left it intact.
What this PR does / why we need it: To have annotations set at the pod level for the kubefed controller. Currently it's only restricted to the deployment level.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1447
Special notes for your reviewer: I have created a new annotation as the previous one committed seems to be incorrect and I didn't want to have any breaking changes related to it.
I have tested the changes in a local kind cluster, below is the output from running the helm upgrades
Added the following in the values.yaml
helm upgrade dry-run
helm upgrade
Also would like to give a special thanks to https://github.com/kiich for helping me out on this change!
Thanks
Nitin