-
Notifications
You must be signed in to change notification settings - Fork 532
Kubernetes 1.18.5 dependency upgrade (plus other upgrades) #1244
Kubernetes 1.18.5 dependency upgrade (plus other upgrades) #1244
Conversation
00d3951
to
e0e2028
Compare
/lgtm |
/verify-owners |
The repo-infra commit will need to be updated to use the version without nico in the owners file. 👍 |
Thanks Bob, I'm just curious, seems |
They have to accept the org membership request first before it will return valid |
Oh, right, that makes sense. |
Another question comes to my mind, why we need to check In this case, we vendors a @mrbobbytables How do you think? Is there anything I didn't know? |
@RainbowMango It should ignore vendor directories and that was the behavior before. Looks like a bug that it doesn't ignore it anymore, I'll check if there were some things changed recently that could affect this behavior. For reference: |
As a side note, should the |
Awesome! Nikhita. I doubt if the vendor is the right choice, maybe a third-part path? |
73b1329
to
2eb2f52
Compare
@RainbowMango I agree that |
Fwiw I've now manually removed the |
@jimmidyson Thanks for your explanation, I didn't know the background before.
@nikhita I guess Prow will check this for every PR. That means prow will set the |
Yes, but it's problematic only for the PRs that would touch |
git-subtree-dir: vendor/k8s.io/repo-infra git-subtree-split: 63918b0966c3f320f7af2a17d85d13f0170ba05c
2eb2f52
to
8055ba6
Compare
Thanks for doing this @jimmidyson |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irfanurrehman, jimmidyson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What this PR does / why we need it:
Upgraded dependencies for Kubernetes 1.18.5 as well as various other small upgrades. Needed to keep up to date with Kubernetes changes and improvements, especially for those projects using kubefed as a library.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Special notes for your reviewer: