Merge pull request #1325 from huiwq1990/imagePullSecrets

add helm parameter imagePullSecrets
kubernetes-retired · Dec 8, 2020 · 21b60ac · 21b60ac
2 parents 9821ccf + c03b6ad
commit 21b60ac
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 0 deletions.
diff --git a/charts/kubefed/README.md b/charts/kubefed/README.md
@@ -103,6 +103,7 @@ chart and their default values.
 | controllermanager.image               | Name of the KubeFed image.                                                                                                                                                                  | kubefed                         |
 | controllermanager.tag                 | Tag of the KubeFed image.                                                                                                                                                                   | latest                          |
 | controllermanager.imagePullPolicy     | Image pull policy.                                                                                                                                                                          | IfNotPresent                    |
+| controllermanager.imagePullSecrets    | Image pull secrets.                                                                                                                                                                         | [] 
 | controllermanager.commonTolerations   | Tolerations for all the pods.                                                                                                                                                               | []                              |
 | controllermanager.commonNodeSelector     | Node selector for all the pods.                                                                                                                                                          | {}                              |
 | controllermanager.featureGates.PushReconciler               | Push reconciler feature.                                                                                                                                              | true                            |

diff --git a/charts/kubefed/charts/controllermanager/templates/deployments.yaml b/charts/kubefed/charts/controllermanager/templates/deployments.yaml
@@ -24,6 +24,10 @@ spec:
         rollme: {{ randAlphaNum 5 | quote }}
       {{- end }}
     spec:
+      {{- if .Values.imagePullSecrets }}
+      imagePullSecrets:
+{{ toYaml .Values.imagePullSecrets | indent 8 }}
+      {{- end }}
       nodeSelector:
         {{- toYaml .Values.commonNodeSelector | nindent 8 }}
       tolerations:
@@ -86,6 +90,10 @@ spec:
         rollme: {{ randAlphaNum 5 | quote }}
       {{- end }}
     spec:
+      {{- if .Values.imagePullSecrets }}
+      imagePullSecrets:
+{{ toYaml .Values.imagePullSecrets | indent 8 }}
+      {{- end }}
       nodeSelector:
         {{- toYaml .Values.commonNodeSelector | nindent 8 }}
       tolerations:

diff --git a/charts/kubefed/values.yaml b/charts/kubefed/values.yaml
@@ -38,6 +38,10 @@ controllermanager:
   #   value: "value"
   #   effect: "NoSchedule"
 
+  ## Ref: https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/
+  imagePullSecrets: []
+  # - name: secretName
+
   controller:
     annotations: {}
     replicaCount: 2