This repository has been archived by the owner on May 25, 2023. It is now read-only.
Support Plugin Arguments #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
k82cn
reviewed
Mar 13, 2019
| @@ -49,4 +49,6 @@ type PluginOption struct { | |||
| PredicateDisabled bool `yaml:"disablePredicate"` | |||
| // NodeOrderDisabled defines whether NodeOrderFn is disabled | |||
| NodeOrderDisabled bool `yaml:"disableNodeOrder"` | |||
| // Arguments defines the different arguments that can be given to different plugins | |||
| Arguments map[string]string `yaml:"arguments"` | |||
There was a problem hiding this comment.
We need to pass the arguments to plugins: update plugin's New to New(args map[string]string).
There was a problem hiding this comment.
Have made those changes
k8s-ci-robot
added
size/M
|
/lgtm please one another PR for weight in |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k82cn, thandayuthapani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Mar 28, 2019
Closed
k8s-ci-robot
added a commit
that referenced
this pull request
Mar 28, 2019
…9-upstream-release-0.4 Automated cherry pick of #639: Support Plugin Arguments
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/scheduler
that referenced
this pull request
Jun 28, 2019
Support Plugin Arguments
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/scheduler
that referenced
this pull request
Jun 28, 2019
Support Plugin Arguments
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/scheduler
that referenced
this pull request
Jun 28, 2019
Support Plugin Arguments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: thandayuthapani [email protected]
What this PR does / why we need it:
Support Plugin Arguments
Which issue(s) this PR fixes
Fixes #637