Fix wrong caculation for deserved in proportion plugin

kubernetes-retired · Mar 27, 2019 · 40c6f18 · 40c6f18
1 parent 38ad28b
commit 40c6f18
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/pkg/scheduler/plugins/proportion/proportion.go b/pkg/scheduler/plugins/proportion/proportion.go
@@ -124,7 +124,8 @@ func (pp *proportionPlugin) OnSessionOpen(ssn *framework.Session) {
 				continue
 			}
 
-			attr.deserved.Add(remaining.Clone().Multi(float64(attr.weight) / float64(totalWeight)))
+			queueDeserved := remaining.Clone().Multi(float64(attr.weight) / float64(totalWeight))
+			attr.deserved.Add(queueDeserved)
 			if !attr.deserved.LessEqual(attr.request) {
 				attr.deserved = helpers.Min(attr.deserved, attr.request)
 				meet[attr.queueID] = struct{}{}
@@ -134,7 +135,7 @@ func (pp *proportionPlugin) OnSessionOpen(ssn *framework.Session) {
 			glog.V(4).Infof("The attributes of queue <%s> in proportion: deserved <%v>, allocate <%v>, request <%v>, share <%0.2f>",
 				attr.name, attr.deserved, attr.allocated, attr.request, attr.share)
 
-			deserved.Add(attr.deserved)
+			deserved.Add(queueDeserved)
 		}
 
 		remaining.Sub(deserved)