This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
Disable configure of cloud route when allocate-node-cidrs is enabled #1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes kubernetes-retired#1336 by adding `--configure-cloud-routes=false` when `--allocate-node-cidrs=true` Added `--cluster-name` to ensure it's set correctly on controller manager. Grouped mandatory and optional flags together.
k8s-ci-robot
added
cncf-cla: yes
|
@davidmccormick for some reason I cannot assign you for review but worth you taking a look at this. |
Codecov Report
@@ Coverage Diff @@
## master #1341 +/- ##
=======================================
Coverage 37.49% 37.49%
=======================================
Files 68 68
Lines 4275 4275
=======================================
Hits 1603 1603
Misses 2447 2447
Partials 225 225Continue to review full report at Codecov.
|
|
@c-knowles Thanks for the fix! LGTM. @ArchiFleKs has also encountered this only with self-hosting enabled. So your choice of adding the flag only for self-hosted configuration looks good. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1336 by adding
--configure-cloud-routes=falsewhen--allocate-node-cidrs=trueAdded
--cluster-nameto ensure it's set correctly on controller manager.Grouped mandatory and optional flags together.