-
Notifications
You must be signed in to change notification settings - Fork 1.3k
bump kubernetes to 1.8 #1844
bump kubernetes to 1.8 #1844
Conversation
4025be4
to
22697c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
func (a *Api) Register(container *restful.Container) {
ws := new(restful.WebService)
ws.Path("/apis/metrics/v1alpha1").
Doc("Root endpoint of metrics API").
Produces(restful.MIME_JSON)
Should the ws.path now be ws.Path("/apis/metrics.k8s.io/v1beta1")
due to the changes to the metrics api in k8s 1.8?
@Joseph-Irving Seems to be what you said. Actually updating the dependencies is painful. :( I have tried more than one day to resolve the changes in apimachinery&&api&&metrics&&others. |
18b78d5
to
c2ab571
Compare
@piosz @DirectXMan12 According to the error info in pull-heapster-e2e:
The go version used for pull-heapster-e2e is go1.7.4 which is too old for |
So I did a bit of digging and it seems that the changes to |
ping @loburm @fgrzadkowski Could you please help to fix the pull-heapster-e2e error described in comment above. |
a3a96a1
to
15fb14f
Compare
15fb14f
to
96eda9e
Compare
96eda9e
to
4bc08ed
Compare
4bc08ed
to
7681f26
Compare
@andyxning: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Adding @loburm who is working on some heapster related changes anyway |
@fgrzadkowski Could you please help to make the pull-heapster-e2e test PR merged first. We need it to run pull-heapster-e2e test. It is really hard to update the complicated dependencies. I am not 100 percent sure that it is right to update all the dependency but i have test the PR with our 1.6.3 cluster. And, seems everything is ok. @fgrzadkowski @loburm Please review the PR for the key points as it is really big to review. :) |
/reopen |
@fgrzadkowski Could you please help to reopen this PR as it is accidentally closed by the @k8s-ci-robot . It is quite confused me that i am the PR author and i have no rights to reopen it. :( |
/reopen |
/cc @loburm |
Something doesn't work with reopening. @andyxning, I think you deleted your branch? |
@fgrzadkowski No. I have not deleted it. It still exists. Could you help me to reopen this. |
I also can't reopen this PR... |
@andyxning don't you mind if I remove your comment with reference to other PR (just a random idea) |
i will give it try. If we can not make it i will open another PR to make it. |
/reopen |
As this PR can not be opened again. I opened another PR #1849 to continue the work on it. :) |
Thanks for checking. I have created issue that describes this issue. |
This PR will bump client-go/api/metrics/apimachinery/kubernetes to 1.8.
As node-problem-detector depends on heapster in some pkgs, we need firs to update heapster to support Kubernetes 1.8 first.
Main changes:
apiVersion
config asCluster
has noAPIVersion
field for now.NodeLegacyHostIP
as it has been deprecated.heapster/metrics/metrics
and usemetrics/pkg/apis/metrics
.metrics
fromv1alpha1
tov1beta1
./cc @DirectXMan12 @piosz