Skip to content
This repository has been archived by the owner on Sep 24, 2021. It is now read-only.

Add streaming Test #224

Merged
merged 1 commit into from
Sep 6, 2017
Merged

Add streaming Test #224

merged 1 commit into from
Sep 6, 2017

Conversation

Lily922
Copy link
Contributor

@Lily922 Lily922 commented Aug 31, 2017

Add unit test to streaming part.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 31, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 31, 2017
@resouer
Copy link
Contributor

resouer commented Sep 3, 2017

@LilyFaFa Awesome work! btw, you can install coverage tool for golang to measure your work.

go get golang.org/x/tools/cmd/cover
go test -coverprofile <filename> <package name>

Then you can measure your work for even single file.

@resouer
Copy link
Contributor

resouer commented Sep 6, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2017
@resouer resouer merged commit 2ec0560 into kubernetes-retired:master Sep 6, 2017
@feiskyer feiskyer mentioned this pull request Sep 27, 2017
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants