-
Notifications
You must be signed in to change notification settings - Fork 115
Add support for more network plugins, e.g. flannel and calico #196
Conversation
cc/ @resouer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some nits, others lgtm
docs/networking.md
Outdated
|
||
## [Flannel](https://github.com/coreos/flannel) | ||
|
||
Remove othe cni network configure if they are already configured: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: other
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack
docs/networking.md
Outdated
|
||
## [Calico](https://www.projectcalico.org) | ||
|
||
Remove othe cni network configure if they are already configured: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: other
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack
Then setup calico plugin by running: | ||
|
||
```sh | ||
kubectl apply -f https://docs.projectcalico.org/v2.4/getting-started/kubernetes/installation/hosted/kubeadm/1.6/calico.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is thiskubeadm/1.6/
implying we should we use k8s 1.6?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it origins from calico's documentation, and supports kubernetes v1.6+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR makes CNI supports old-versioned plugins. And also adds support for more network plugins, e.g. flannel and calico
Closes: #69 #150