Skip to content
This repository has been archived by the owner on Jul 16, 2024. It is now read-only.

Restart the server using the recommended etcd version #361

Merged

Conversation

justinsb
Copy link
Contributor

@justinsb justinsb commented Feb 3, 2023

When we load a version from disk, we run the latest recommended patch
version. This enables us to depend on fewer versions of etcd.

Co-authored-by: Justin SB

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 3, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 3, 2023
@justinsb justinsb force-pushed the etcd-version-for-adoption branch from 7be59b0 to c4f6fdf Compare February 4, 2023 16:10
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 4, 2023
@justinsb justinsb force-pushed the etcd-version-for-adoption branch from c4f6fdf to 7ede3a4 Compare February 4, 2023 16:42
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 4, 2023
When we load a version from disk, we run the latest recommended patch
version.  This enables us to depend on fewer versions of etcd.

Co-authored-by: Justin SB <[email protected]>
@justinsb justinsb force-pushed the etcd-version-for-adoption branch from 7ede3a4 to 647e80d Compare February 4, 2023 17:17
@justinsb justinsb changed the title WIP: Do we need to switch all versions? Restart the server using the recommended etcd version Feb 4, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 4, 2023
@justinsb
Copy link
Contributor Author

justinsb commented Feb 4, 2023

I think this is a minimal version - WDYT @hakman ?

/assign @hakman

Of course, the really tricky thing is that we need to figure out how to test this, we need an upgrade test that runs an otherwise unsupported version of etcd I guess and then does an upgrade...

@hakman
Copy link
Contributor

hakman commented Feb 4, 2023

Thanks @justinsb. Looks great!
We have in kOps a test for upgrade which should be good in this case:
pull-kops-e2e-aws-upgrade-126-ko126-to-klatest-kolatest-many-addons

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5c8e13c into kubernetes-retired:master Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants